Fixes #12210: In technique editor, on save, we get "success" but some errors are shallowed #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
requested changes
Nov 14, 2018
| } | ||
| var saveError = function(action, data) { | ||
| return $scope.handle_error("while "+action+" Technique '"+ data.technique.name+"'") | ||
| return handle_error("while "+action+" Technique '"+ data.technique.name+"'") | ||
| } | ||
|
|
||
| // Actually save the technique through API |
There was a problem hiding this comment.
This should be:
// Actually save the technique through API
if ($scope.originalTechnique.bundle_name === undefined) {
$http.post("/ncf/api/techniques", data).success(saveSuccess).error(saveError("creating", data)).finally(function(){$scope.$broadcast('endSaving');});
} else {
$http.put("/ncf/api/techniques", data).success(saveSuccess).error(saveError("saving", data)).finally(function(){$scope.$broadcast('endSaving');});
}
fanf
requested changes
Nov 14, 2018
builder/js/ncf.js
Outdated
| @@ -1112,44 +1113,53 @@ $scope.onImportFileChange = function (fileEl) { | |||
| ncfTechnique = data.data.data.technique; | |||
…me errors are shallowed
VinceMacBuche
force-pushed
the
bug_12210/in_technique_editor_on_save_we_get_success_but_some_errors_are_shallowed
branch
from
3badec2
to
bd2560e
Compare
|
Commit modified |
fanf
approved these changes
Nov 14, 2018
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/12210